Parameter validation refactor #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-stachowiak
changed the base branch from
development
to
parameter-validation
Introduction of the parameter validation callbacks implemented in terms of setjmp/longjmp causes certain tests compilation to raise warning about clobbering certain variables. This happens when the are not allocated on the stack. Disabling the compiler optimizations prevents the warnings from being raised. Note that the `-O0` option is present in the Makefile, whereas it is not used when building with CMake.
simonbutcher
reviewed
Dec 8, 2018
| @@ -2,7 +2,7 @@ | |||
| # To compile on SunOS: add "-lsocket -lnsl" to LDFLAGS | |||
| # To compile with PKCS11: add "-lpkcs11-helper" to LDFLAGS | |||
|
|
|||
| CFLAGS ?= -O2 | |||
| CFLAGS ?= -O0 | |||
There was a problem hiding this comment.
Mainly as a note to myself....
I don't think this is a good way to suppress a warning.
The actual warning (which is gcc specific) is -Wclobbered, so should be suppressed with -Wno-clobbered. However, clang doesn't recognise the parameter -Wno-clobbered and we don't have a compiler specific means of passing CFLAGS at the moment, so that won't work.
Therefore, if we needed to suppress the warning, may be a better means to suppress it would be in the source file itself to detect gcc and pragma a warning away. The following seems to work:
#if defined(MBEDTLS_CHECK_PARAMS)
#if defined(__GNUC__) && !defined(__clang__)
#pragma GCC diagnostic ignored "-Wno-uninitialized"
#endif
#endif /* MBEDTLS_CHECK_PARAMS */
However - I don't think we should be disabling warnings here, so this shouldn't be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR presents changes suggested for easier client side use of the parameter validation check failure. Limits the parameter validation failure callback to a default function provided with Mbed TLS, that can be substituted by user provided callback at run time.