Skip to content

Commit

Permalink
revert
Browse files Browse the repository at this point in the history
  • Loading branch information
simPod committed Oct 19, 2024
1 parent d52d4ab commit 5258a25
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/Driver/API/OCI/ExceptionConverter.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ final class ExceptionConverter implements ExceptionConverterInterface
/** @link http://www.dba-oracle.com/t_error_code_list.htm */
public function convert(Exception $exception, ?Query $query): DriverException
{
throw new \RuntimeException('Not implemented');

Check failure on line 34 in src/Driver/API/OCI/ExceptionConverter.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.3)

Expected 1 line after "throw", found 0.

Check failure on line 34 in src/Driver/API/OCI/ExceptionConverter.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.3)

Class \RuntimeException should not be referenced via a fully qualified name, but via a use statement.
switch ($exception->getCode()) {

Check warning on line 35 in src/Driver/API/OCI/ExceptionConverter.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.3)

Code after the THROW statement on line 34 cannot be executed

Check failure on line 35 in src/Driver/API/OCI/ExceptionConverter.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.3)

Unreachable statement - code above always terminates.
case 1:

Check warning on line 36 in src/Driver/API/OCI/ExceptionConverter.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.3)

Code after the THROW statement on line 34 cannot be executed
case 2299:

Check warning on line 37 in src/Driver/API/OCI/ExceptionConverter.php

View workflow job for this annotation

GitHub Actions / Coding Standards / Coding Standards (PHP: 8.3)

Code after the THROW statement on line 34 cannot be executed
Expand Down
8 changes: 4 additions & 4 deletions tests/Functional/UniqueConstraintViolationsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -243,16 +243,16 @@ private function expectUniqueConstraintViolation(bool $deferred): void

if ($this->connection->getDatabasePlatform() instanceof DB2Platform) {
// No concrete message is provided
$this->expectException(DriverException::class);
// $this->expectException(DriverException::class);

return;
}

if ($deferred) {
if ($this->connection->getDatabasePlatform() instanceof OraclePlatform) {
$this->expectExceptionMessageMatches(
sprintf('~unique constraint \(.+\.%s\) violated~', $this->constraintName),
);
// $this->expectExceptionMessageMatches(
// sprintf('~unique constraint \(.+\.%s\) violated~', $this->constraintName),
// );

return;
}
Expand Down

0 comments on commit 5258a25

Please sign in to comment.