Skip to content

Commit

Permalink
Revert workaround of bundling in react-keyed-flatten-children
Browse files Browse the repository at this point in the history
  • Loading branch information
axelboc committed Aug 16, 2023
1 parent 5da1e6a commit 8ab5680
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 36 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ import.

The build process of`@h5web/h5wasm` is also the same as the lib's, but since the
package does not include any styles, `vite build` does not generate a
`style.css` file and there's not `build:css` script.
`style.css` file and there's no `build:css` script.

Finally, since `@h5web/shared` is not a published package, it does not need to
be built with Vite. However, its types do need to be built with `tsc` so that
Expand Down
2 changes: 1 addition & 1 deletion packages/lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"ndarray-ops": "1.2.2",
"react-aria-menubutton": "7.0.3",
"react-icons": "4.8.0",
"react-keyed-flatten-children": "1.3.0",
"react-keyed-flatten-children": "2.2.1",
"react-measure": "2.5.2",
"react-slider": "2.0.4",
"react-window": "1.8.8",
Expand Down
4 changes: 1 addition & 3 deletions packages/lib/vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ const [pkg, sharedPkg] = ['.', '../shared'].map((prefix) =>

export const externals = new Set([
...Object.keys(sharedPkg.peerDependencies),
...Object.keys(pkg.dependencies).filter(
(dep) => dep !== 'react-keyed-flatten-children', // Fix https://github.com/silx-kit/h5web/issues/914
),
...Object.keys(pkg.dependencies),
...Object.keys(pkg.peerDependencies),
]);

Expand Down
84 changes: 53 additions & 31 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8ab5680

Please sign in to comment.