Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Update API to reflect changes to CLI interaction #600

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli marked this pull request as draft August 28, 2024 02:12
@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-sake branch 6 times, most recently from 85ff5f0 to e7e982a Compare September 4, 2024 08:34
@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-sake branch 3 times, most recently from 074b013 to bd29712 Compare September 17, 2024 01:12
@GuySartorelli GuySartorelli marked this pull request as ready for review September 17, 2024 02:27
@GuySartorelli GuySartorelli force-pushed the pulls/6/symfony-sake branch 3 times, most recently from 411d762 to 1689968 Compare September 25, 2024 00:14
@@ -28,7 +28,7 @@ This obfuscation is handled by the [`NameObfuscator`](api:SilverStripe\GraphQL\S
There are various implementations:

- [`NaiveNameObfuscator`](api:SilverStripe\GraphQL\Schema\Storage\NaiveNameObfuscator): Filename/Classname === Type name (debug only)
- [`HybridNameObfuscator`](api:SilverStripe\GraphQL\Schema\Storage\HybridNameObfuscator): Filename/Classname is a mix of the typename and a md5 hash (default).
- [`PolyNameObfuscator`](api:SilverStripe\GraphQL\Schema\Storage\PolyNameObfuscator): Filename/Classname is a mix of the typename and a md5 hash (default).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't nor should be renamed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops yes, good catch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -6,7 +6,7 @@
/**
* Hashed for less discoverability, but still readable if you focus on it
*/
class HybridObfuscator implements NameObfuscator
class PolyObfuscator implements NameObfuscator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert naming change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@emteknetnz emteknetnz merged commit 54d2357 into silverstripe:6 Sep 26, 2024
4 of 10 checks passed
@emteknetnz emteknetnz deleted the pulls/6/symfony-sake branch September 26, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants