Merge branch '5.1' into 5

silverstripe · Nov 5, 2023 · d6f0cec · d6f0cec
2 parents 4c66b57 + 5b40be3
commit d6f0cec
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 8 deletions.
diff --git a/src/Auth/Handler.php b/src/Auth/Handler.php
@@ -21,10 +21,7 @@ class Handler
      * @config
      * @var array
      *
-     * @internal Experimental config:
-     * @todo Move this to a per-schema configuration and refer to this schema from the current endpoint
-     * @link https://github.com/silverstripe/silverstripe-graphql/issues/58
-     * @link https://github.com/silverstripe/silverstripe-graphql/issues/52
+     * @internal Experimental config
      */
     private static $authenticators = [
         [

diff --git a/src/Middleware/QueryCachingMiddleware.php b/src/Middleware/QueryCachingMiddleware.php
@@ -111,8 +111,6 @@ protected function getCachedResponse(string $key): ?array
 
         // On cache success validate against cached classes
         foreach ($cached['classes'] as $class) {
-            // Note: Could combine these clases into a UNION to cut down on extravagant queries
-            // Todo: We can get last-deleted/modified as well for versioned records
             $lastEditedDate = DataObject::get($class)->max('LastEdited');
             if (strtotime($lastEditedDate ?? '') > strtotime($cached['date'] ?? '')) {
                 // class modified, fail validation of cache

diff --git a/src/Schema/DataObject/InterfaceBuilder.php b/src/Schema/DataObject/InterfaceBuilder.php
@@ -65,8 +65,6 @@ public function createInterfaces(ModelType $modelType, array $interfaceStack = [
         )
             ->setTypeResolver([AbstractTypeResolver::class, 'resolveType']);
 
-        // TODO: this makes a really good case for
-        // https://github.com/silverstripe/silverstripe-graphql/issues/364
         $validPlugins = [];
         foreach ($modelType->getPlugins() as $name => $config) {
             $plugin = $modelType->getPluginRegistry()->getPluginByID($name);