MNT Behat-test fixtures for elemental area #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
requested changes
May 9, 2022
There was a problem hiding this comment.
Because this module is used to add test fixtures for a number of modules, it would be better to avoid using "blog post" (which could seem like it's intended to be used with the blog module). Can you please rename things in a way that makes it clear it's for the elemental module?
e.g. instead of BlogPostsAdmin use ElementalBehatAdmin or something along those lines.
Maybe even put the source files all into a shared elemental directory (similar to some of the others like tagfield etc)
sabina-talipova
force-pushed
the
pulls/4/behat-tests-elemental-area
branch
from
8e2697a
to
94420d7
Compare
GuySartorelli
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Three new classes TestBlogPost, TestBlogPostAdmin and TestBlogPostExtension to support behat tests cases in silverstripe/silverstripe-elemental
Parent Issue