FIX Get array values, not keys #11414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Oct 2, 2024
Comment on lines
+93
to
+110
| public function testAllowedProtocols(): void | ||
| { | ||
| $field = new UrlField('MyUrl'); | ||
| // Defaults should be http and https | ||
| $this->assertSame(['https', 'http'], $field->getAllowedProtocols()); | ||
|
|
||
| // Defaults change with config, and ignore keys | ||
| UrlField::config()->set('default_protocols', ['my-key' => 'ftp']); | ||
| $this->assertSame(['ftp'], $field->getAllowedProtocols()); | ||
|
|
||
| // Can set explicit protocols - again keys are ignored | ||
| $field->setAllowedProtocols(['http', 'key' => 'irc', 'nntp']); | ||
| $this->assertSame(['http', 'irc', 'nntp'], $field->getAllowedProtocols()); | ||
|
|
||
| // Can reset back to config defaults | ||
| $field->setAllowedProtocols([]); | ||
| $this->assertSame(['ftp'], $field->getAllowedProtocols()); | ||
| } |
There was a problem hiding this comment.
Can't use a dataprovider here, these need to happen sequentially.
This was referenced Oct 2, 2024
emteknetnz
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the values, not the keys. We're just converting a potential associative array to an indexed one.
Should be done on
getnotsetin case associative array values are set in the config, too.Issue
symfony/validatorfor as much validation logic as we can throw at it. .github#193