Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Update test to reflect changes to template/model layers #1260

Merged
merged 1 commit into from
Oct 30, 2024
Merged

MNT Update test to reflect changes to template/model layers #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/ElementalAreaTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ public function testGetOwnerPage()
// OwnerClassName set
$ownerpage2 = $area2->getOwnerPage();

$this->assertEquals("DNADesign\Elemental\Tests\Src\TestPage", $ownerpage1);
$this->assertEquals("DNADesign\Elemental\Tests\Src\TestPage", $ownerpage2);
$this->assertInstanceOf(TestPage::class, $ownerpage1);
$this->assertInstanceOf(TestPage::class, $ownerpage2);
Comment on lines -81 to +82
Copy link
Member Author

@GuySartorelli GuySartorelli Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was always just a bad test that relied on ModelData::__toString() returning the class name.
This change isn't necessary anymore since I had to revert the change to what that method returns, but I think this change is still objectively good and worth doing. Check the class to check the class, ya know?


// if ownerpage1 has draft changes then getOwnerPage() should return the
// live version of the owner page, since the draft record will be
Expand Down
Loading