Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some bits in the readme #1101

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fix some bits in the readme #1101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
215fadf
Fix some bits in the readme
edwilde Sep 19, 2023
eeb4546
Revert Github specific markdown to maintain portability
edwilde Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ For a Silverstripe CMS 4.1 or 4.2 compatible version of this module, please see
```sh
composer require dnadesign/silverstripe-elemental
```
composer require dnadesign/silverstripe-elemental
```

The following YAML config will enable elements on every `Page` object,
replacing the standard `Content` rich text field.
Expand Down Expand Up @@ -210,8 +208,8 @@ If in-line editing is not disabled, whilst not having a custom component defined
After building your own React components and including them into the CMS, altering the applicable Element's PHP definition to use the new React component can be achieved by setting some `protected` properties of that class.

```php
protected $schemaDataType = FormField::SCHEMA_DATA_TYPE_CUSTOM;
protected $schemaComponent = 'BlockLinkField';
protected $schemaDataType = FormField::SCHEMA_DATA_TYPE_CUSTOM;
protected $schemaComponent = 'BlockLinkField';
```

- The `$schemaDataType` does not need to be CUSTOM, but should not be STRUCTURAL as structural types are not submitted as form data.
Expand Down