FIX Use canDelete, not the now-deleted canArchive #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Note that behat failures are pre-existing, and are unrelated to this PR. |
GuySartorelli
force-pushed
the
pulls/3/candelete-is-canarchive
branch
from
cf4a6a8
to
4c599dd
Compare
GuySartorelli
force-pushed
the
pulls/3/candelete-is-canarchive
branch
from
4c599dd
to
d8fa1f6
Compare
emteknetnz
approved these changes
Aug 15, 2024
emteknetnz
pushed a commit
to creative-commoners/silverstripe-asset-admin
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canArchive()is removed in favour ofcanDelete()in silverstripe/silverstripe-versioned#460Issue
canArchive()method for CMS 6 silverstripe-versioned#447