Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix js lint errors #1388

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 22, 2023

Issue silverstripe/.github#99

I did a merge-up from 2.0 => 2 though there were some yarn lint failures which I choose to ignore for the sake of completing the merge-up without having to commit changes without a PR. I've fixed the yarn lint errors in this PR

The yarn lint errors were

vendor/silverstripe/asset-admin/client/src/containers/AssetAdmin/AssetAdmin.js
  686:13  error  'archiveFiles' is assigned a value but never used  no-unused-vars

vendor/silverstripe/asset-admin/client/src/containers/BulkDeleteConfirmation/BulkDeleteMessage.js
  78:5  error  Prefer fragment shorthand over React.Fragment  react/jsx-fragments

vendor/silverstripe/asset-admin/client/src/containers/BulkDeleteConfirmation/DeletionModal.js
  22:1  error  Expected indentation of 8 spaces but found 10  indent

Note this PR is only fixing lint issues, there is a broken behat test on this which will be an existing failure

@GuySartorelli
Copy link
Member

there is a broken behat test on this which will be an existing failure

Is there a PR to fix that?

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was going to merge up and rerun the behat tests but the auto-merger will fail because of the linting issues and I can't be bothered merging up manually for unrelated behat failures. So, good to go.

@GuySartorelli GuySartorelli merged commit 4f8cd92 into silverstripe:2 Aug 23, 2023
10 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/lint branch August 23, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants