Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS so TinyMCE sslink popup windows show over fullscreen #1816

Conversation

lianna-blanca
Copy link

@lianna-blanca lianna-blanca commented Aug 22, 2024

Description

When using TinyMCE in CMS 5.2, the editor's full screen mode hides the pop-up windows which allow users to configure links. This applies to all types of links (internal, external, file, anchor, email, phone).

This appears to be due to the TinyMCE fullscreen mode having a z-index of 1200, whereas the popup windows are at 1050. When I manually change this in chrome dev tools, the popups appear over the full screen as they should.

Manual testing steps

  1. Go to any TinyMCE editor field which has buttons for full screen and for SSLink
  2. Open full screen mode
  3. Select some text and press the SSLink button, and select any option from the dropdown field
  4. Observe that no popup appears
  5. Close full screen mode; observe that the popup for editing that link type is now visible.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@lianna-blanca lianna-blanca changed the base branch from 2 to 2.2 August 22, 2024 21:42
@lianna-blanca lianna-blanca changed the base branch from 2.2 to 2 August 22, 2024 21:43
@lianna-blanca lianna-blanca changed the title Update CSS so TinyMCE sslink popup windows show over fullscreen Fix CSS so TinyMCE sslink popup windows show over fullscreen Aug 22, 2024
@lianna-blanca lianna-blanca changed the base branch from 2 to 2.2 August 23, 2024 01:24
@lianna-blanca lianna-blanca changed the base branch from 2.2 to 2 August 23, 2024 01:24
@lianna-blanca lianna-blanca deleted the bugfix/Adjust-TinyMCE-sslink-popup-zindex branch August 23, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant