MNT Run module-standardiser #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
GuySartorelli
requested changes
May 16, 2024
There was a problem hiding this comment.
This PR adds the phpstan stuff, but no phplinting job is in the CI run. We should either not include phpstan stuff for recipes, or make sure to include PHP linting in their CI runs.
I'd suggest not including it - everything in a recipe is included in projects and I don't think we want projects to have our idiosyncratic module-related standards enforced.
emteknetnz
force-pushed
the
pulls/5/module-standardiser-1715811569
branch
from
13b4a39
to
b173fd0
Compare
|
Have removed and updated module-standardiser to not include it in future |
GuySartorelli
requested changes
May 16, 2024
emteknetnz
force-pushed
the
pulls/5/module-standardiser-1715811569
branch
from
b173fd0
to
319c176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request was created automatically by module-standardiser