NEW Update issue/PR templates on default branches #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
GuySartorelli
commented
Dec 20, 2023
| @@ -196,7 +201,7 @@ | |||
| // force pushing for cases when doing update-prs | |||
| // double make check we're on a branch that we are willing to force push | |||
| $currentBranch = cmd('git rev-parse --abbrev-ref HEAD', $MODULE_DIR); | |||
| if (!preg_match('#^pulls/[0-9\.]+/module\-standardiser\-[0-9]{10}$#', $currentBranch)) { | |||
| if (!preg_match('#^pulls/([0-9\.]+|master|main)/module\-standardiser\-[0-9]{10}$#', $currentBranch)) { | |||
There was a problem hiding this comment.
I could also have changed this to [a-zA-Z0-9\.] but I really doubt we'll ever come across a different-named branch, and if we do it's probably best we take a look and make sure things are doing what we expected them to do.
emteknetnz
requested changes
Dec 20, 2023
| about: ⚠️ We do not use GitHub issues to track security vulnerability reports. Click "open" on the right to see how to report security vulnerabilities. | ||
| - name: Support Question | ||
| url: https://www.silverstripe.org/community/ | ||
| about: We use GitHub issues only to discuss about bugs and new features. For support questions, please use one of the support options available in our community channels. |
There was a problem hiding this comment.
Suggested change
| about: We use GitHub issues only to discuss about bugs and new features. For support questions, please use one of the support options available in our community channels. | |
| about: We only use GitHub issues to discuss bugs and new features. For support questions, please use one of the support options available in our community channels. |
There was a problem hiding this comment.
As discussed in person, I'll keep "only" where it is and remove "about"
|
|
||
| // The template used for bug report issues | ||
| $bugReportTemplate = <<<EOT | ||
| name: 🐛 Bug Report |
There was a problem hiding this comment.
May as well use the cockroach
| attributes: | ||
| label: How to reproduce | ||
| description: | | ||
| ⚠️ This is the most important part of the report ⚠️ |
There was a problem hiding this comment.
Suggested change
| ⚠️ This is the most important part of the report ⚠️ | |
| ⚠️ This is the most important part of the report ⚠️ |
| --> | ||
| - # | ||
|
|
||
| ## PR merge checklist |
There was a problem hiding this comment.
Suggested change
| ## PR merge checklist | |
| ## Pull-request checklist |
There was a problem hiding this comment.
Done but without the hyphen
| EOT; | ||
|
|
||
| // The template used when clicking "Open a blank issue" | ||
| $defaultIssueTemplate = "<!-- Blank templates are for use by maintainers only! If you aren't a maintainer, please pick one of the issue templates. -->"; |
There was a problem hiding this comment.
Suggested change
| $defaultIssueTemplate = "<!-- Blank templates are for use by maintainers only! If you aren't a maintainer, please pick one of the issue templates. -->"; | |
| $defaultIssueTemplate = "<!-- Blank templates are for use by maintainers only! If you aren't a maintainer, please go back and pick one of the issue templates. -->"; |
GuySartorelli
force-pushed
the
pulls/main/issue-and-pr-templates
branch
from
ef0405c
to
28ebe37
Compare
emteknetnz
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github-defaultoption for the--branchoptiondefault-branchdir.masterormain, and some of them are for CMS 4 branchesIssue