CMS 5 upgrade #37
Open
CMS 5 upgrade #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevKCode
force-pushed
the
upgrade/cms-5-upgrade
branch
from
b5b7cfc
to
9fc9794
Compare
DevKCode
force-pushed
the
upgrade/cms-5-upgrade
branch
2 times, most recently
from
2d3c857
to
3cd695d
Compare
DevKCode
force-pushed
the
upgrade/cms-5-upgrade
branch
from
3cd695d
to
05982ea
Compare
pack254
reviewed
Aug 22, 2024
_config/config.yml
Outdated
| @@ -3,5 +3,5 @@ Name: logviewerconfig | |||
| --- | |||
| SilverStripe\Core\Injector\Injector: | |||
| Psr\Log\LoggerInterface: | |||
| calls: | |||
| AddDataObjectHandler: [ pushHandler, [ %$SilverLeague\LogViewer\Handler\DataObjectHandler ] ] | |||
| calls: | |||
There was a problem hiding this comment.
I spot this bug and it will break when run composer dev-build. calls should be 1 indentation further.
pack254
force-pushed
the
upgrade/cms-5-upgrade
branch
from
06b2b11
to
b1a2b97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the packages to CMS 5 version