Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write ps1 script to download data #900

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

psh0078
Copy link
Collaborator

@psh0078 psh0078 commented Jun 26, 2024

Fix #880

Write a script that checks if data files already exist and if their checksum matches the expected checksum. If the files do not exist or their checksum does not match, the script will download the required zip files.

@psh0078 psh0078 self-assigned this Jun 26, 2024
@psh0078 psh0078 requested a review from rmunn June 26, 2024 08:55
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pretty large change requested here, sorry. But my intent, which I may not have explained well enough, was that the script would take parameters, and the hash values (and URLs) would be hardcoded in the Taskfile.yml file, not in the script.

Taskfile.yml Outdated Show resolved Hide resolved
download.ps1 Outdated Show resolved Hide resolved
download.ps1 Outdated Show resolved Hide resolved
@psh0078 psh0078 requested a review from rmunn July 1, 2024 06:41
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. This is ready to merge now.

@rmunn
Copy link
Contributor

rmunn commented Jul 2, 2024

Note that this is going to create merge conflicts with #888 which adds a third project. That's fine; we'll just resolve the merge conflicts in #888 once this is merged.

@psh0078 psh0078 merged commit bae23a1 into develop Jul 2, 2024
3 checks passed
@rmunn rmunn mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove -Resume parameter from Invoke-Webrequest commands in task setup
2 participants