bring FLEx lite poc into lexbox #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L has been returned from a call to a COM component. The error code is E_FAIL, or EFail, or 0x80004005.` error by disabling build options in debug mode
… issue with rounding down
…f a middleware that's configuring the project context
# Conflicts: # frontend/pnpm-lock.yaml # frontend/viewer/package.json
UI unit Tests11 tests 11 ✅ 0s ⏱️ Results for commit ff718d8. ♻️ This comment has been updated with latest results. |
C# Unit Tests57 tests 57 ✅ 11s ⏱️ Results for commit ff718d8. ♻️ This comment has been updated with latest results. |
myieye
reviewed
May 23, 2024
…ct between assemblies
…nsistent client id on a single client.
|
1deb7d4 seems to indicate that the new abstract change classes were a good move. A bunch of code just vanished 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLEx lite is the WeSay/LF replacement, right now it's just an aspnet core server that when run launches the users browser, we'll probably turn this into some kind of electron app in the future.
This also adds a CrdtCommits table to lexbox to facilitate syncing data. This should be considered experimental and subjet to change.There's also no auth right now, so this won't work as is, we need to get the openId stuff figured out and merged in before that will work. However FLEx lite is designed with offline in mind, so it'll work fine if it can't contact lexbox.
right now all the local webapp code lives in the backend folder, not sure that's the correct place for it. Thoughts?