Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up languagedepot namespace in task setup #803

Merged
merged 1 commit into from
May 17, 2024

Conversation

rmunn
Copy link
Contributor

@rmunn rmunn commented May 16, 2024

This will avoid Skaffold deleting the languagedepot namespace when you run skaffold delete, so it doesn't have to be re-created each time.

The change to the ingress-deployment.yaml file is necessary because Kustomize was changing the ingress-nginx namespaces in there to languagedepot anyway, and therefore Skaffold was still deleting the languagedepot namespace when running skaffold delete because it was being created by ingress-deployment.yaml. Now that ingress-deployment.yaml uses the languagedepot namespace instead, and assumes it already exists, running skaffold delete; task up goes a lot faster.

Fixes #605.

This will avoid Skaffold deleting the languagedepot namespace when you
run `skaffold delete`, so it doesn't have to be re-created each time.
@rmunn rmunn requested review from myieye and megahirt May 16, 2024 05:52
@rmunn
Copy link
Contributor Author

rmunn commented May 16, 2024

There's one thing that's still slow about running skaffold delete; task up, which is redownloading the large .zip files from Google Drive. I tried to fix that in #758, but discovered that it's just not possible (AFAICT) to get a file from your dev machine into a Kubernetes volume running under Docker Desktop. If anyone knows how to do that, please let me know.

Taskfile.yml Show resolved Hide resolved
@rmunn rmunn merged commit 0e6739a into develop May 17, 2024
3 checks passed
@rmunn rmunn self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak Skaffold setup so it doesn't create languagedepot namespace
3 participants