Bug/401 from the backend during ssr will crash the node server #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myieye
force-pushed
the
bug/352-401-from-the-backend-during-ssr-will-crash-the-node-server
branch
from
ede88cb
to
fd4490b
Compare
myieye
force-pushed
the
bug/352-401-from-the-backend-during-ssr-will-crash-the-node-server
branch
from
fd4490b
to
959f1b1
Compare
myieye
force-pushed
the
bug/352-401-from-the-backend-during-ssr-will-crash-the-node-server
branch
2 times, most recently
from
c153e70
to
05cf3f6
Compare
hahn-kev
approved these changes
Nov 8, 2023
|
@hahn-kev the more complicated a PR is the less change-requests you get so... |
myieye
force-pushed
the
bug/352-401-from-the-backend-during-ssr-will-crash-the-node-server
branch
from
05cf3f6
to
4c3d407
Compare
myieye
force-pushed
the
bug/352-401-from-the-backend-during-ssr-will-crash-the-node-server
branch
from
4c3d407
to
fde27f1
Compare
|
For the record, the last commit got a bit overloaded, it also contains a few error tracing additions and changes. For one, I started trying to log trace IDs in server-code, in the hope that it's easier to debug error logs. |
myieye
deleted the
bug/352-401-from-the-backend-during-ssr-will-crash-the-node-server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #352.
The first 2 commits are the functional changes and are small.
The 3rd commit is big, but only tests.
It was a bit messy deciding exactly what cases I should test. But, all the interesting things are covered I think...and some more.