Feat (312): stabilize client side otel export #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at #312
If an export fails it gets retried with XHR. We can try a more ambitious export size now, because it doesn't matter as much if it fails. Also, a higher number helps us pump things through faster, so it's less likely that we'll lose something on page unload. I initially thought we'd lose insight into export failures this way, but I think that's not really the case, because either:
There's of course the 3rd scenario: when the error would have been reported before: (1) we start the retry instead, (2) the page gets unloaded and (3) the XHR/retry gets canceled and we can't report the failure. But that shouldn't happen too often.
Of course, we're not really trying to instrument our instrumentation export failures, but it is nice to know if it's not working well.