Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (312): stabilize client side otel export #341

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Oct 23, 2023

An attempt at #312

If an export fails it gets retried with XHR. We can try a more ambitious export size now, because it doesn't matter as much if it fails. Also, a higher number helps us pump things through faster, so it's less likely that we'll lose something on page unload. I initially thought we'd lose insight into export failures this way, but I think that's not really the case, because either:

  1. We'll just retry with XHR and it will probably be ok, so the failure doesn't matter
  2. It's too late to retry and so we likely wouldn't see the failure anyway

There's of course the 3rd scenario: when the error would have been reported before: (1) we start the retry instead, (2) the page gets unloaded and (3) the XHR/retry gets canceled and we can't report the failure. But that shouldn't happen too often.

Of course, we're not really trying to instrument our instrumentation export failures, but it is nice to know if it's not working well.

@myieye myieye force-pushed the 312-stabilize-client-side-otel-export branch from d96d341 to 3f3dcf0 Compare October 23, 2023 13:44
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

UI unit Tests

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 4c16f6c. ± Comparison against base commit 7a7d781.

♻️ This comment has been updated with latest results.

@myieye myieye force-pushed the 312-stabilize-client-side-otel-export branch from 3f3dcf0 to 40a4bd7 Compare October 23, 2023 13:46
@myieye myieye force-pushed the 312-stabilize-client-side-otel-export branch from 0ef1e6e to e1ebd5d Compare October 27, 2023 11:21
@myieye myieye force-pushed the 312-stabilize-client-side-otel-export branch from e1ebd5d to 4c16f6c Compare October 27, 2023 12:03
@myieye myieye merged commit 638d0e7 into develop Oct 27, 2023
6 checks passed
@myieye myieye deleted the 312-stabilize-client-side-otel-export branch October 27, 2023 12:12
@myieye myieye linked an issue Nov 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize client-side OTEL export
2 participants