Add paging user list #328
Closed
Add paging user list #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myieye
force-pushed
the
add-paging-user-list
branch
from
820df07
to
2f6ea43
Compare
hahn-kev
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Great work Tim, nice job on the icontains filter especially.
The only major thing is the debounce of the user filter, otherwise it looks good. We should make a separate issue to display a spinner in the user search bar while results are loading, otherwise it might look like the search isn't doing anything.
backend/LexBoxApi/GraphQL/CustomFilters/CustomFilterOperations.cs
Outdated
Show resolved
Hide resolved
backend/LexBoxApi/GraphQL/CustomFilters/QueryableStringDeterministicInvariantContainsHandler.cs
Outdated
Show resolved
Hide resolved
backend/LexBoxApi/GraphQL/CustomFilters/QueryableStringDeterministicInvariantContainsHandler.cs
Outdated
Show resolved
Hide resolved
backend/LexBoxApi/GraphQL/CustomFilters/QueryableStringDeterministicInvariantContainsHandler.cs
Outdated
Show resolved
Hide resolved
myieye
force-pushed
the
add-paging-user-list
branch
from
8a873ac
to
728a667
Compare
|
@hahn-kev ready for another review 😁 |
hahn-kev
approved these changes
Oct 19, 2023
myieye
force-pushed
the
add-paging-user-list
branch
from
728a667
to
18638be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #319
Adds server-side paging to the admin user-table to prevent memory problems.
Additionally filtering projects by user-membership is now done in the DB with GQL, so we don't have an N-projects*M-users on the server or client.
Only return explicitly requested query-params prevented the new user-search query-param from landing in the project filter bar. In other scenarios we could pick the required params/props higher up, but this seems like a good default behaviour anyway and fixes the problem.