Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.1.4 -- resolve lint warnings #283

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Release 10.1.4 -- resolve lint warnings #283

merged 5 commits into from
Oct 13, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Oct 9, 2024

Fixed

  • Resolve some of the lint warnings identified by PhpStorm

@briskt briskt requested a review from a team as a code owner October 9, 2024 07:08
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team October 9, 2024 07:08
briskt
briskt commented Oct 10, 2024
View reviewed changes
Copy link
Contributor Author

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diving into a big review!

features/fakes/FakeIdBrokerClient.php Outdated Show resolved Hide resolved
features/fakes/FakeIdBrokerClient.php Outdated Show resolved Hide resolved
modules/mfa/public/send-manager-mfa.php Show resolved Hide resolved
modules/mfa/src/Auth/Process/Mfa.php Show resolved Hide resolved
modules/mfa/src/Auth/Process/Mfa.php Show resolved Hide resolved
modules/sildisco/public/metadata.php Show resolved Hide resolved
modules/sildisco/src/Auth/Process/AddIdp2NameId.php Outdated Show resolved Hide resolved
modules/sildisco/src/IdPDisco.php Show resolved Hide resolved
modules/sildisco/src/IdPDisco.php Show resolved Hide resolved
modules/profilereview/src/Auth/Process/ProfileReview.php Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics
hobbitronics reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel unqualified to give much of a meaningful review, but overall looks like some good improvements and clean up!

@briskt briskt changed the title Release 10.1.2 -- resolve lint warnings Release 10.1.3 -- resolve lint warnings Oct 10, 2024
jason-jackson
jason-jackson approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it seems fine. It's odd that you use both arrays and pointers to arrays, but then again SSP does that too. Might be nice to standardize.

modules/mfa/src/Auth/Process/Mfa.php Show resolved Hide resolved
@briskt
Copy link
Contributor Author

briskt commented Oct 11, 2024

In general it seems fine. It's odd that you use both arrays and pointers to arrays, but then again SSP does that too. Might be nice to standardize.

The PhpStorm recommendation was to remove pass-by-reference where the value doesn't change.

@briskt briskt changed the title Release 10.1.3 -- resolve lint warnings Release 10.1.4 -- resolve lint warnings Oct 11, 2024
@briskt briskt merged commit 54fe050 into main Oct 13, 2024
3 checks passed
@briskt briskt deleted the clear-minor-warnings branch October 13, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtompset mtompset mtompset left review comments

@hobbitronics hobbitronics hobbitronics left review comments

@jason-jackson jason-jackson jason-jackson approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@briskt @mtompset @jason-jackson @hobbitronics