Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.1.0 - update last_login_utc from inside mfa #281

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Release 10.1.0 - update last_login_utc from inside mfa #281

merged 11 commits into from
Oct 7, 2024

Conversation

hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics requested a review from a team as a code owner September 20, 2024 06:19
@hobbitronics hobbitronics requested review from briskt, forevermatt, mtompset and jason-jackson and removed request for a team September 20, 2024 06:19
@hobbitronics
Copy link
Contributor Author

Woops, looks like this isn't quite ready yet.

@hobbitronics hobbitronics reopened this Sep 20, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hobbitronics and others added 5 commits September 26, 2024 06:26
@hobbitronics
update last_login_utc in mfa process
cadb1be
@briskt
fix typo in variable name
9d5260c
@briskt
print logs if tests fail
ef2a122
@briskt
Revert "print logs if tests fail"
d049464 
This reverts commit ef2a122.
@briskt
don't let simplesamlphp/simplesamlphp upgrade to 2.3 -
85bf331 
because that project does not adhere to semantic versioning, breaking changes are allowed in the second version segment as well as the first
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

briskt
briskt approved these changes Oct 7, 2024
View reviewed changes
composer.json Show resolved Hide resolved
modules/mfa/src/Auth/Process/Mfa.php Show resolved Hide resolved
@hobbitronics hobbitronics merged commit 2d8f4dd into main Oct 7, 2024
3 checks passed
@hobbitronics hobbitronics deleted the idp-781 branch October 7, 2024 03:51
@hobbitronics hobbitronics changed the title Idp 781 update last_login_utc from inside mfa Release 10.1.0 - update last_login_utc from inside mfa Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt left review comments

@mtompset mtompset mtompset left review comments

@briskt briskt briskt approved these changes

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hobbitronics @briskt @forevermatt @mtompset