Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove config options that are not used #268

Merged
merged 6 commits into from
Jul 22, 2024
Merged

remove config options that are not used #268

merged 6 commits into from
Jul 22, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 19, 2024 •
edited
Loading

Removed

  • Removed originalUrlParam
  • Removed excludeByDefault
  • Removed IDP_NAME and IDP_DISPLAY_NAME and use the metadata name property instead
  • Removed SAML20_IDP_ENABLE
  • Removed SESSION_DURATION

Note: to study each removal separately, look at each commit one-by-one.

https://itse.youtrack.cloud/issue/IDP-1041

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

forevermatt
forevermatt approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah for cutting stuff we don't need any more 😁

@briskt briskt merged commit 2fab743 into develop Jul 22, 2024
3 checks passed
@briskt briskt deleted the feature/idp-1041 branch July 22, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

@hobbitronics hobbitronics Awaiting requested review from hobbitronics

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @forevermatt