Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove browser check for webauthn support #262

Merged
merged 2 commits into from
Jul 18, 2024
Merged

remove browser check for webauthn support #262

merged 2 commits into from
Jul 18, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jul 18, 2024

Removed

  • Removed browser check for webauthn support
  • Removed abandoned package sinergi/browser-detector

hobbitronics
hobbitronics approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@briskt briskt merged commit 0e8ad80 into develop Jul 18, 2024
3 checks passed
@briskt briskt deleted the browser/remove-browser-detector branch July 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt

@mtompset mtompset Awaiting requested review from mtompset

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics