-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
combine actions-services and docker-compose config #242
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but how do you get rid of the port number.
I may not understand your question. The last commit on this PR does away with the port number for that one container. Are you asking something else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Now to use extension fields to reuse the environment variables.
Yeah, I was just wondering why you were able to do that. |
Ah, yes, good question. I'm not 100% sure, but it may have to do with some of the tests having been disabled. If a problem surfaces at the time I reenable those tests, I'm sure there's a good solution. |
Changed