Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine actions-services and docker-compose config #242

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 24, 2024

Changed

  • Merged actions-services.yml into docker-compose.yml
  • Removed 8084 port assignment from pwmanager container to bypass an unexpected conflict. (This container is not used in manual testing and does not need a local port.)

@briskt briskt requested a review from a team June 24, 2024 08:34
Copy link

sonarcloud bot commented Jun 24, 2024

Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but how do you get rid of the port number.

@briskt
Copy link
Contributor Author

briskt commented Jun 25, 2024

Looks good, but how do you get rid of the port number.

I may not understand your question. The last commit on this PR does away with the port number for that one container. Are you asking something else?

Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Now to use extension fields to reuse the environment variables.

@hobbitronics
Copy link
Contributor

Looks good, but how do you get rid of the port number.

I may not understand your question. The last commit on this PR does away with the port number for that one container. Are you asking something else?

Yeah, I was just wondering why you were able to do that.

@briskt
Copy link
Contributor Author

briskt commented Jun 25, 2024

Looks good, but how do you get rid of the port number.

I may not understand your question. The last commit on this PR does away with the port number for that one container. Are you asking something else?

Yeah, I was just wondering why you were able to do that.

Ah, yes, good question. I'm not 100% sure, but it may have to do with some of the tests having been disabled. If a problem surfaces at the time I reenable those tests, I'm sure there's a good solution.

docker-compose.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
Base automatically changed from feature/ssp2-loginuserpass-twig to develop June 28, 2024 17:22
@briskt briskt merged commit 1383c69 into develop Jun 28, 2024
3 checks passed
@briskt briskt deleted the feature/remove-actions-services branch June 28, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants