Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace cleanup #240

Merged
merged 4 commits into from
Jun 28, 2024
Merged

whitespace cleanup #240

merged 4 commits into from
Jun 28, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 21, 2024

Changed

  • Used PhpStorm "Reformat Code" to clean up whitespace.

tests/MetadataTest.php Outdated Show resolved Hide resolved
@mtompset
Copy link

Most of my comments are likely related to:
"When the argument list is split across multiple lines, the closing parenthesis and opening brace MUST be placed together on their own line with one space between them." (https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments)
"When you have a return type declaration present, there MUST be one space after the colon followed by the type declaration. The colon and declaration MUST be on the same line as the argument list closing parenthesis with no spaces between the two characters. ... ): string {"

Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've resolved the comments

@briskt
Copy link
Contributor Author

briskt commented Jun 25, 2024

Most of my comments are likely related to: "When the argument list is split across multiple lines, the closing parenthesis and opening brace MUST be placed together on their own line with one space between them." (https://www.php-fig.org/psr/psr-12/#45-method-and-function-arguments) "When you have a return type declaration present, there MUST be one space after the colon followed by the type declaration. The colon and declaration MUST be on the same line as the argument list closing parenthesis with no spaces between the two characters. ... ): string {"

Thanks for bringing this to my attention. I naively assumed that the default phpStorm settings would be PSR-12 compliant.

Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

Base automatically changed from feature/remove-fingerprint to develop June 28, 2024 16:48
Copy link

sonarcloud bot commented Jun 28, 2024

@briskt briskt merged commit 2b36ad0 into develop Jun 28, 2024
2 checks passed
@briskt briskt deleted the feature/whitespace-cleanup branch June 28, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants