Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert profile review templates to Twig #238

Merged
merged 10 commits into from
Jun 28, 2024
Merged

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 20, 2024

Changed

  • Converted profile review templates to Twig
  • Disabled remaining tests that are not yet passing: sildisco, status

@briskt briskt requested a review from hobbitronics June 25, 2024 04:04
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition of rel=noopener

Base automatically changed from feature/ssp2-codes-twig to develop June 26, 2024 03:06
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jason-jackson's question about review vs review.php is the only possible problem I noticed.

Copy link

sonarcloud bot commented Jun 28, 2024

@briskt briskt merged commit d7c08a7 into develop Jun 28, 2024
3 checks passed
@briskt briskt deleted the feature/ssp2-nag-twig branch June 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants