Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert about2expire template to Twig #233

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 19, 2024

Changed

  • Converted about2expire template to Twig

@briskt briskt requested a review from hobbitronics June 25, 2024 04:04
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

</p>

<div class="fill-parent" layout-children="row" child-spacing="space-around">
<button name="continue" class="mdl-button mdl-button--raised">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button name="continue" class="mdl-button mdl-button--raised">
<button name="continue" type="submit" class="mdl-button mdl-button--raised">

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

{{ '{about2expire:button_continue}'|trans }}
</button>

<button name="changepwd" class="mdl-button mdl-button--raised mdl-button--primary">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button name="changepwd" class="mdl-button mdl-button--raised mdl-button--primary">
<button name="changepwd" type="submit" class="mdl-button mdl-button--raised mdl-button--primary">

Base automatically changed from feature/ssp2-selectidp-twig to develop June 25, 2024 07:12
Copy link

sonarcloud bot commented Jun 25, 2024

@briskt briskt merged commit 4b8a3bd into develop Jun 25, 2024
1 of 2 checks passed
@briskt briskt deleted the feature/ssp2-about2expire-twig branch June 25, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants