Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 10.0.0-alpha.3 -- more cleanup and prep for SSP 2 #226

Merged
merged 18 commits into from
Jun 17, 2024
Merged

Release 10.0.0-alpha.3 -- more cleanup and prep for SSP 2 #226

merged 18 commits into from
Jun 17, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Jun 14, 2024 •
edited
Loading

Added

  • Added notes about manual testing to README.

Changed (non-breaking)

  • Added saml, core, and admin modules to the module.enable config entry to prepare for SimpleSAMLphp 2.x. (IDP-892)

Removed

  • Removed memcache option for session storage. (IDP-1041)
  • Removed TIMEZONE config option. (IDP-1041)
  • Removed GOOGLE_ENABLE option. (IDP-1041)

Fixed

  • Removed the hyphen from "docker compose".
  • Removed the version line from actions-services.yml.
  • Removed "--rm" from docker compose lines in the GitHub Actions workflow.

briskt added 18 commits June 12, 2024 20:14
@briskt
add notes about manual testing
6f8b132
@briskt
Replace "docker-compose" with "docker compose"
6fad609
@briskt
remove "version" from actions-services.yml
9f42d23
@briskt
remove "--rm" from compose commands run on GitHub
19f8cfb
@briskt
modules aren't needed on the test SPs
4395010
@briskt
remove GOOGLE_ENABLE option since we never use it
927772e
@briskt
remove TIMEZONE config option
3a5afe7
@briskt
remove memcached
fa52c71
@briskt
revert accidental change to Dockerfile
91a5aa6
@briskt
remove ext-memcached from composer.lock
3f951ce
@briskt
keep SESSION_STORE_TYPE for local dev and for test
8648adb
@briskt
enable saml, core, and admin modules in all config files
0a5503c
@briskt
Merge pull request #221 from silinternational/feature/remove-memcache
7feb725 
remove memcache option
@briskt
Merge pull request #222 from silinternational/feature/enable-modules
2860f3c 
enable saml, core, and admin modules in all config files
@briskt
Merge pull request #217 from silinternational/feature/docker-compose
82f5fb8 
update docker compose
@briskt
Merge pull request #219 from silinternational/feature/manual-test-note
2914b37 
add notes about manual testing
@briskt
Merge pull request #220 from silinternational/feature/remove-timezone
a94f8ba 
remove TIMEZONE config option
@briskt
Merge pull request #218 from silinternational/feature/remove-google
657fee2 
remove GOOGLE_ENABLE
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
64.2% Duplication on New Code

See analysis details on SonarCloud

jason-jackson
jason-jackson approved these changes Jun 14, 2024
View reviewed changes
docker-compose.yml Show resolved Hide resolved
mtompset
mtompset approved these changes Jun 14, 2024
View reviewed changes
Copy link

@mtompset mtompset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So scrolling on a phone to review

@briskt briskt merged commit a3d2040 into main Jun 17, 2024
4 checks passed
forevermatt
forevermatt reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work you did on this. 👍

Vagrantfile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt left review comments

@mtompset mtompset mtompset approved these changes

@jason-jackson jason-jackson jason-jackson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@briskt @forevermatt @mtompset @jason-jackson