Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistent use of maps for docker-compose environment #206

Merged
merged 2 commits into from
May 28, 2024
Merged

consistent use of maps for docker-compose environment #206

merged 2 commits into from
May 28, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented May 27, 2024

Fixed

  • Make consistent the use of YAML map for environment variables in docker compose

hobbitronics
hobbitronics approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question.

actions-services.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@briskt briskt merged commit 2ea9c29 into develop May 28, 2024
3 checks passed
@briskt briskt deleted the feature/consistent-environment branch May 28, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbitronics hobbitronics hobbitronics approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt

@jason-jackson jason-jackson Awaiting requested review from jason-jackson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @hobbitronics