Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in eduPersonTargetedId field name... and anything depending on it #204

Open
briskt opened this issue May 27, 2024 · 0 comments

Comments

@briskt
Copy link
Contributor

briskt commented May 27, 2024

The attributes returned by any IdP using this SilAuth repo currently contain an eduPersonTargetId (incorrect) field, rather than an eduPersonTargetedId (correct) field:
https://github.com/silinternational/simplesamlphp-module-silauth/blob/8e8eb79b543a5689145f232247e3efb426c997ca/src/saml/User.php#L21

There are a handful of other places where we have also made this mistake:
https://github.com/search?q=org%3Asilinternational+eduPersonTargetID&type=Code

As a first step in resolving this, we'll probably need to make sure no SP's are depending on this mistyped version of that field name.

(Original issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant