Skip to content
This repository has been archived by the owner on Jun 25, 2024. It is now read-only.

Correct typo in eduPersonTargetedId field name... and anything depending on it? #52

Closed
forevermatt opened this issue Mar 29, 2018 · 3 comments

Comments

@forevermatt
Copy link
Contributor

The attributes returned by any IdP using this SilAuth repo currently contain an eduPersonTargetId (incorrect) field, rather than an eduPersonTargetedId (correct) field:

'eduPersonTargetID' => (array)$uuid,

There are a handful of other places where we have also made this mistake:
https://github.com/search?q=org%3Asilinternational+eduPersonTargetID&type=Code

As a first step in resolving this, we'll probably need to make sure no SP's are depending on this mistyped version of that field name.

@devon-sil
Copy link

Adding to our backlog.

@forevermatt
Copy link
Contributor Author

If I remember correctly, there is also an authproc that we are/should-be using to generate the real eduPersonTargetedId attribute... though that's just going from memory, so it might not be correct. I believe there are places where we are doing this correctly now, so searching our metadata might provide a correct example now. Just for what that's worth.

@briskt
Copy link
Contributor

briskt commented May 27, 2024

Moved to ssp-base repo

@briskt briskt closed this as completed May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants