Skip to content

Commit

Permalink
add noopener to other links that use target=_blank
Browse files Browse the repository at this point in the history
  • Loading branch information
briskt committed Jun 20, 2024
1 parent 11cf23b commit a2159a9
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion modules/material/locales/en/LC_MESSAGES/material.po
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ msgid "{mfa:webauthn_instructions}"
msgstr "You may now insert your security key and press its button."

msgid "{mfa:webauthn_unsupported}"
msgstr "Unsupported in your current browser. Please consider a more secure browser like <a href='https://www.google.com/chrome/browser' target='_blank'>Google Chrome</a>."
msgstr "Unsupported in your current browser. Please consider a more secure browser like <a href='https://www.google.com/chrome/browser' target='_blank' rel=noopener'>Google Chrome</a>."

msgid "{mfa:webauthn_error_unknown}"
msgstr "Something went wrong with that request, unable to verify at this time."
Expand Down
2 changes: 1 addition & 1 deletion modules/material/locales/es/LC_MESSAGES/material.po
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ msgid "{mfa:webauthn_instructions}"
msgstr "Ahora puede insertar su clave de seguridad y presionar su botón."

msgid "{mfa:webauthn_unsupported}"
msgstr "No compatible en su navegador actual. Considere un navegador más seguro como <a href='https://www.google.com/chrome/browser' target='_blank'>Google Chrome</a>."
msgstr "No compatible en su navegador actual. Considere un navegador más seguro como <a href='https://www.google.com/chrome/browser' target='_blank' rel='noopener'>Google Chrome</a>."

msgid "{mfa:webauthn_error_unknown}"
msgstr "Algo salió mal con esa solicitud, no se pudo verificar en este momento."
Expand Down
2 changes: 1 addition & 1 deletion modules/material/locales/fr/LC_MESSAGES/material.po
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ msgid "{mfa:webauthn_instructions}"
msgstr "Vous pouvez maintenant insérer votre clé de sécurité et appuyer sur le bouton."

msgid "{mfa:webauthn_unsupported}"
msgstr "Non compatible avec votre navigateur actuel. Veuillez considérer un navigateur plus sûr comme <a href='https://www.google.com/chrome/browser' target='_blank'>Google Chrome</a>."
msgstr "Non compatible avec votre navigateur actuel. Veuillez considérer un navigateur plus sûr comme <a href='https://www.google.com/chrome/browser' target='_blank' rel='noopener'>Google Chrome</a>."

msgid "{mfa:webauthn_error_unknown}"
msgstr "Quelque chose s'est mal passé avec cette demande, impossible de vérifier pour le moment."
Expand Down
2 changes: 1 addition & 1 deletion modules/material/locales/ko/LC_MESSAGES/material.po
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ msgid "{mfa:webauthn_instructions}"
msgstr "이제 보안 키를 삽입하고 단추를 누를 수 있습니다."

msgid "{mfa:webauthn_unsupported}"
msgstr "현재 브라우저에서 지원되지 않습니다. <a href='https://www.google.com/chrome/browser' target='_blank'>Chrome과</a> 같은 보다 안전한 브라우저를 고려하십시오."
msgstr "현재 브라우저에서 지원되지 않습니다. <a href='https://www.google.com/chrome/browser' target='_blank' rel='noopener'>Chrome과</a> 같은 보다 안전한 브라우저를 고려하십시오."

msgid "{mfa:webauthn_error_unknown}"
msgstr "요청에 문제가 발생하여 지금은 확인할 수 없습니다."
Expand Down
6 changes: 3 additions & 3 deletions modules/material/themes/material/core/loginuserpass.php
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ function onRecaptchaLoad() {
$forgotPasswordUrl = htmlentities($this->configuration->getValue('passwordForgotUrl'));
if (! empty($forgotPasswordUrl)) {
?>
<a href="<?= $forgotPasswordUrl ?>" target="_blank" class="mdl-button mdl-button--colored mdl-typography--caption">
<a href="<?= $forgotPasswordUrl ?>" target="_blank" rel="noopener" class="mdl-button mdl-button--colored mdl-typography--caption">
<?= $this->t('{material:login:forgot}') ?>
</a>
<?php
Expand All @@ -141,13 +141,13 @@ function onRecaptchaLoad() {

<section layout-children="row" child-spacing="space-around">
<?php if (! empty($this->data['helpCenterUrl'])): ?>
<a href="<?= $this->data['helpCenterUrl'] ?>" target="_blank" class="mdl-button mdl-button--colored mdl-typography--body-2">
<a href="<?= $this->data['helpCenterUrl'] ?>" target="_blank" rel="noopener" class="mdl-button mdl-button--colored mdl-typography--body-2">
<?= $this->t('{material:login:help}') ?> <i class="material-icons">launch</i>
</a>
<?php endif; ?>

<?php if (! empty($this->data['profileUrl'])): ?>
<a href="<?= $this->data['profileUrl'] ?>" target="_blank" class="mdl-button mdl-button--colored mdl-typography--body-2">
<a href="<?= $this->data['profileUrl'] ?>" target="_blank" rel="noopener" class="mdl-button mdl-button--colored mdl-typography--body-2">
<?= $this->t('{material:login:profile}') ?> <i class="material-icons">launch</i>
</a>
<?php endif; ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

{% if not helpCenterUrl ?? '' is empty %}
<nav class="mdl-navigation">
<a href="{{ helpCenterUrl }}" target="_blank" class="mdl-navigation__link">
<a href="{{ helpCenterUrl }}" target="_blank" rel="noopener" class="mdl-navigation__link">
{{ '{selectidp-links:help}'|trans }}
</a>
</nav>
Expand Down
2 changes: 1 addition & 1 deletion modules/material/themes/material/profilereview/review.twig
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
</section>

<section layout-children="row" child-spacing="end" class="fill-parent margin">
<a href="{{ profileUrl }}" target="_blank" onclick="document.querySelector('button').click()"
<a href="{{ profileUrl }}" target="_blank" rel="noopener" onclick="document.querySelector('button').click()"
class="mdl-button mdl-button--colored" layout-children="row">
{{ '{review:button_update}'|trans }} <i class="material-icons">launch</i>
</a>
Expand Down

0 comments on commit a2159a9

Please sign in to comment.