Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.10.4 - Update dependencies #382

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

forevermatt
Copy link
Contributor

Fixed

  • Update dependencies

PR Checklist

  • Put version number in PR title (e.g. Release x.y.z - Summary of changes)
  • Run make composershow
  • Run make psr2

@forevermatt forevermatt requested a review from a team as a code owner October 29, 2024 15:50
@forevermatt forevermatt requested review from briskt, mtompset, jason-jackson and hobbitronics and removed request for a team October 29, 2024 15:50
Copy link

sonarcloud bot commented Oct 29, 2024

Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to fix the workflow to not push to GHCR on feature branches, or we need to not use slashes in branch names.

@forevermatt
Copy link
Contributor Author

Looks like we need to fix the workflow to not push to GHCR on feature branches, or we need to not use slashes in branch names.

Yeah, I noticed that and was wondering what to do about it. Apparently there's an output you can use for getting those tags (hopefully in a format that works for tags, i.e. replacing slashes with hyphens). I'm also fine with only pushing docker images for the main branch, if you prefer that approach.

@forevermatt
Copy link
Contributor Author

forevermatt commented Oct 30, 2024

Looks like we need to fix the workflow to not push to GHCR on feature branches, or we need to not use slashes in branch names.

Yeah, I noticed that and was wondering what to do about it. Apparently there's an output you can use for getting those tags (hopefully in a format that works for tags, i.e. replacing slashes with hyphens). I'm also fine with only pushing docker images for the main branch, if you prefer that approach.

Here's the approach using an output to get the tags, but I don't know if we need to upgrade to version 6 of that GitHub Action to be able to use it (I would guess not...):
https://docs.docker.com/build/ci/github-actions/manage-tags-labels/#:~:text=steps.meta.outputs.tags

@briskt
Copy link
Contributor

briskt commented Oct 30, 2024

I'm also fine with only pushing docker images for the main branch, if you prefer that approach.

That's the direction I've been going lately.

@forevermatt forevermatt merged commit 9a8c6fe into main Oct 30, 2024
2 of 3 checks passed
@forevermatt forevermatt deleted the feature/update-dependencies branch October 30, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants