Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushing Docker Image to GHCR.io #379

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Pushing Docker Image to GHCR.io #379

merged 2 commits into from
Oct 21, 2024

Conversation

Praveenraj-K
Copy link
Contributor

Added

  • Added step to push the docker image to Github Container Registry

@Praveenraj-K Praveenraj-K requested a review from a team as a code owner October 21, 2024 08:31
@Praveenraj-K Praveenraj-K requested review from briskt, forevermatt, mtompset and hobbitronics and removed request for a team October 21, 2024 08:31
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

briskt
briskt approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also remember that repos with a develop branch should be merged from a feature branch. I understand it's confusing because we have these two different types of repos.

@Praveenraj-K Praveenraj-K merged commit 7532e91 into main Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Praveenraj-K @briskt