Release 6.8.0 - Add field and API endpoint for external groups (i.e. not from the HR system) #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally Yii updates their template for Active Record model files. It seems more helpful to see the effects of those changes in that same PR (where Yii was updated), rather than seeing them in a later, unrelated PR. Updating the base models only takes around 10 seconds, so it seems like a minimal time cost (percentage-wise) that we're adding to each composer update call.
Update base models, and do so with each "make composerupdate"
PHP's `explode()` returns an array with an empty string if the given string is empty, but we do not want to add that to the `members` list.
This is easily obtained (with the ID as a link, even) by clicking the "Copy ID and summary to clipboard" icon beside a YouTrack issue's ID link, near the top-left of the page when viewing an issue in a sufficiently-wide browser window.
This helps reduce the complexity of the `User->fields()` method, which was getting overly complicated.
…uest-template Refine ID Broker's pull-request template
…oups-external-field [IDP-1176] Add `groups_external` field to User
…oups-external-field-part-2 [IDP-1176] Add `groups_external` field, part 2 (cleanup)
…-groups-external [IDP-1182] Add endpoint for updating `groups_external`
|
|
Replacing with #357 (release PR from a release branch, to avoid later merges to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDP-1176 Add groups_external field to ID Broker's database
IDP-1182 Provide a way to set
user.groups_externalAdded
groups_externalfield to UserChanged (non-breaking)
groups_externalvalues in a User'smemberlist during loginFixed
User->getMemberList()method