Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: briskt <[email protected]>
  • Loading branch information
hobbitronics and briskt authored Sep 19, 2024
1 parent 7e32ba1 commit 0b47032
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
14 changes: 8 additions & 6 deletions api.raml
Original file line number Diff line number Diff line change
Expand Up @@ -458,12 +458,14 @@ types:
200:
description: Successfully updated the last login time.
body:
application/json:
example: |
{
"employee_id": "f6bf51f2-4ccc-4d85-8f75-02132c67af27",
"last_login_utc": "2024-09-18T12:34:56Z"
}
properties:
employee_id: string
last_login_utc: string
example: |
{
"employee_id": "12345",
"last_login_utc": "2024-09-18T12:34:56Z"
}
404:
description: Not found. The user with the specified `employeeId` was not found.
500:
Expand Down
3 changes: 1 addition & 2 deletions application/features/user.feature
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,13 @@ Feature: User

Scenario: update the last_login_utc of an existing user
Given the requester is authorized
And I add a user with a employee_id of "123"
And I add a user with an employee_id of "123"
And a record exists with an employee_id of "123"
When I request "/user/123/update-last-login" be updated
Then the response status code should be "200"
And a record exists with an employee_id of "123"
And last_login_utc should be stored as now UTC
And the only property to change should be last_login_utc
#* @Then /^a record exists with (?:a|an) (.*) of "?([^"]*)"?$/

Scenario: Deactivate an existing user
Given a record does not exist with an employee_id of "123"
Expand Down

0 comments on commit 0b47032

Please sign in to comment.