Add Rekor Bundle message #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkatalin
force-pushed
the
rekor-bundle
branch
2 times, most recently
from
de70969
to
04b7b58
Compare
Signed-off-by: Lily Sturmann <[email protected]>
lkatalin
changed the title
|
|
||
| // The RekorBundle is the signed material used to produce the Signed Entry | ||
| // Timestamp signature. See notes on the InclusionPromise above. | ||
| message RekorBundle { |
There was a problem hiding this comment.
Have we confirmed that when marshalled as json as canonicalized, this works as expected? Just want to make sure there's no issues with field naming.
There was a problem hiding this comment.
I can run some tests soon. No need to wait on this PR for the new release.
There was a problem hiding this comment.
@lkatalin I'll plan to include this in a 0.3.2 release with the other change for the checkpoint key ID that just went in.
woodruffw
reviewed
Apr 8, 2024
|
|
||
| // The RekorBundle is the signed material used to produce the Signed Entry | ||
| // Timestamp signature. See notes on the InclusionPromise above. | ||
| message RekorBundle { |
There was a problem hiding this comment.
naming nit: I don't want to proliferate "bundle" even though it's in cosign, given we want "bundle" to refer to top level protobuf bundle now. Do you have another suggestion of the name? SignedEntryTimestampContents?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #261
Related to sigstore/rekor#1943
I'm considering whether the RekorBundle struct would make more sense as bytes (like the
canonicalized body), with the tradeoff of readability, so I may update this. (Or possibly we could have both, but that may be too verbose.)Edit: Updated based on the conversation in #261 to be separate from the TLE message.