policy-controller: fix empty values #835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes the issue where only the key is output when the value is not provided for some fields such as
.Values.annotations
and.Values.webhook.podDisruptionBudget.maxUnavailable
.Existing or Associated Issue(s)
Additional Information
The state in which only the key is output, such as
annotations:
, is not syntactically correct in yaml, so lint tools such as kubeconform output an error.In this PR, the position of the conditional branch has been slightly changed so that if value is not specified, key is also not output.
$ helm install policy-controller sigstore/policy-controller -n policy-controller --dry-run > old.yaml
$ helm install policy-controller ./charts/policy-controller -n policy-controller --dry-run > new.yaml
$ dyff between .\old.yaml .\new.yaml
old.yaml:
new.yaml:
Output:
Checklist
Chart.yaml
according to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.