Drop the .cluster.local suffix
#804
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this is the standard suffix, it is configurable and not necessarily accurate. Just using `.svc` and relying on ndots it used elsewhere through the helm chart, so drop the qualification here. Signed-off-by: Matt Moore <[email protected]>
mattmoor
force-pushed
the
drop-cluster-local
branch
from
093f067
to
3afa1f3
Compare
priyawadhwa
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
While
.cluster.localis the standard suffix, it is configurable and not necessarily accurate.Just using
.svcand relying on ndots it used elsewhere through the helm chart, so drop the qualification here.Existing or Associated Issue(s)
N/A
Additional Information
N/A
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.