Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helper for fulcio config yaml #803

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

javanlacerda
Copy link
Contributor

@javanlacerda javanlacerda commented Jul 31, 2024

Description of the change

I noticed that this condition was not working properly when I was bumping the fulcio version in scaffold.

Then I managed to move the logic of create the config with yaml format into the helper and setting the indent correctly.

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@javanlacerda javanlacerda force-pushed the javan.fix-fulcio-helper branch 2 times, most recently from b1918f5 to fc26fd7 Compare July 31, 2024 17:59
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, what was the error you were getting with the previous code?

charts/fulcio/templates/fulcio-configmap.yaml Outdated Show resolved Hide resolved
@javanlacerda
Copy link
Contributor Author

javanlacerda commented Aug 1, 2024

Just wondering, what was the error you were getting with the previous code?

I've got this one:

Error: INSTALLATION FAILED: 1 error occurred:  ConfigMap in version "v1" cannot be handled as a ConfigMap: json: cannot unmarshal object into Go struct field ConfigMap.data of type string

haydentherapper
haydentherapper previously approved these changes Aug 1, 2024
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, this was tested locally with json and yaml configs and was working?

@javanlacerda
Copy link
Contributor Author

To confirm, this was tested locally with json and yaml configs and was working?

I tested for the default value, that is json. I'm doing a double check here.

Signed-off-by: Javan lacerda <[email protected]>
@javanlacerda
Copy link
Contributor Author

To confirm, this was tested locally with json and yaml configs and was working?

I tested for the default value, that is json. I'm doing a double check here.

It is 100% tested now, working properly for json and yaml

@haydentherapper haydentherapper merged commit 6901d5c into sigstore:main Aug 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants