add additional env variables to fulcio chart #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Racer159
force-pushed
the
feat/fulcio-env-gcp
branch
from
dbd368c
to
674cab3
Compare
|
On this though would it make sense to use a pattern more similar to Rekor for extra env vars? https://github.com/sigstore/helm-charts/blob/main/charts/rekor/templates/server/deployment.yaml#L105 - it may be nice in many cases to pull env vars from secrets rather than pass them through Helm values. (i.e. |
Racer159
force-pushed
the
feat/fulcio-env-gcp
branch
from
674cab3
to
de59237
Compare
Support GCP credentials for external cloud provider workloads Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Co-authored-by: saisatish karra <[email protected]> Signed-off-by: Wayne Starr <[email protected]>
Signed-off-by: Wayne Starr <[email protected]>
Signed-off-by: Wayne Starr <[email protected]>
Racer159
force-pushed
the
feat/fulcio-env-gcp
branch
from
de59237
to
a2f7ddf
Compare
|
(would also like to make a similar change to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Support GCP credentials for external cloud provider workloads and add additional env vars for specifying values like
VAULT_ADDRExisting or Associated Issue(s)
This is a repickup of #530
Additional Information
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.