Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom annotations in Policy Controller pods #767

Merged

Conversation

gsantos-hc
Copy link
Contributor

@gsantos-hc gsantos-hc commented Jun 25, 2024

Description of the change

Add the ability to customize annotations on Policy Controller pods.

Existing or Associated Issue(s)

Fixes #766

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@cpanato
Copy link
Member

cpanato commented Jun 26, 2024

please sign the DCO

@gsantos-hc gsantos-hc force-pushed the feat/policy-controller-annotations branch from a0c179b to d2a1363 Compare June 26, 2024 12:54
@bobcallaway
Copy link
Member

pls bump the version, otherwise LGTM

@gsantos-hc gsantos-hc force-pushed the feat/policy-controller-annotations branch from d2a1363 to d5c464e Compare July 2, 2024 14:00
@gsantos-hc
Copy link
Contributor Author

Force-pushed to rebase from the latest main and update the chart version.

@vipulagarwal
Copy link
Contributor

@gsantos-hc can you also update the JSON schema as well please?

@gsantos-hc gsantos-hc force-pushed the feat/policy-controller-annotations branch from d5c464e to 3ae3ef9 Compare July 2, 2024 14:14
@vipulagarwal
Copy link
Contributor

LGTM

@gsantos-hc gsantos-hc force-pushed the feat/policy-controller-annotations branch from 3ae3ef9 to 79dd94d Compare September 5, 2024 20:43
@gsantos-hc
Copy link
Contributor Author

Force-pushed to rebase against latest main. Would it be possible to have this merged?

@bobcallaway bobcallaway merged commit 6136454 into sigstore:main Sep 5, 2024
3 checks passed
@gsantos-hc gsantos-hc deleted the feat/policy-controller-annotations branch September 5, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom annotations on Policy Controller pods
4 participants