fix: add ingress create boolean #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortesnoel-lm
changed the title
cortesnoel-lm
changed the title
cpanato
requested changes
Jun 16, 2023
cortesnoel-lm
force-pushed
the
tuf-ingress-optional
branch
from
dea0eea
to
57abe18
Compare
Signed-off-by: Noel Cortes <[email protected]>
Signed-off-by: Noel Cortes <[email protected]>
Signed-off-by: Noel Cortes <[email protected]>
cortesnoel-lm
force-pushed
the
tuf-ingress-optional
branch
from
4a9c343
to
fd6d5b1
Compare
|
Noting here, I made all the recommended changes and resolved the convos. Is there anything else needed from me to merge? |
hectorj2f
approved these changes
Jun 23, 2023
cpanato
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adding .Values.ingress.create to tuf helm chart and wrapping tuf's ingress.yaml in an if block using that new "create" value. This way users can opt-in to tuf's ingress.yaml like some of the other chart objects.
Existing or Associated Issue(s)
Additional Information
Baiscally same pattern as tuf's namespace.yaml in templates dir. I left default value as true to not introduce breaking changes.
Checklist
Chart.yamlaccording to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.