Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trillian: switch to chainguard/netcat #545

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Jun 13, 2023

Description of the change

Switch to chainguard/netcat image for multiarch support (amd64 and arm64)

Fixes: #500

Existing or Associated Issue(s)

#500

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

hectorj2f
hectorj2f previously approved these changes Jun 13, 2023
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sabre1041
Copy link
Contributor

@tuananh would you be able to resolve the conflict?

tuananh-vpbank and others added 2 commits June 25, 2023 18:34
@tuananh
Copy link
Contributor Author

tuananh commented Jun 25, 2023

@tuananh would you be able to resolve the conflict?

just rebase with main & resolve conflict

@sabre1041
Copy link
Contributor

@tuananh everything looks good. Just need a bump on the chart version and we can merge

Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sabre1041 sabre1041 merged commit d82e555 into sigstore:main Jun 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to Chainguard's netcat image
4 participants