Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect if user supplied a valid protobuf bundle #3931

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

steiza
Copy link
Member

@steiza steiza commented Nov 11, 2024

Summary

Fixes #3930

Several users, when trying out the new verification with protobuf bundles, first left off --new-bundle-format. We can detect if the user supplies a protobuf bundle, and assume they want to use the new verification flow.

Release Note

  • Detect if you used a new protobuf bundle for cosign verify-blob and cosign verify-blob-attestation, even if you leave off --new-bundle-format

Documentation

N/A

Even if they leave off `--new-bundle-format`

Signed-off-by: Zach Steindler <[email protected]>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.36%. Comparing base (2ef6022) to head (2f7d720).
Report is 238 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3931      +/-   ##
==========================================
- Coverage   40.10%   36.36%   -3.74%     
==========================================
  Files         155      209      +54     
  Lines       10044    13382    +3338     
==========================================
+ Hits         4028     4867     +839     
- Misses       5530     7889    +2359     
- Partials      486      626     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@haydentherapper haydentherapper merged commit 7952891 into sigstore:main Nov 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect if new protocol buffer bundle is being used for verification
2 participants