feat: no check model's support for function calls (#791)

sigoden · Aug 16, 2024 · 580ed6b · 580ed6b
1 parent 7a95bd5
commit 580ed6b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 12 deletions.
diff --git a/src/client/model.rs b/src/client/model.rs
@@ -187,10 +187,6 @@ impl Model {
         self.data.supports_vision
     }
 
-    pub fn supports_function_calling(&self) -> bool {
-        self.data.supports_function_calling
-    }
-
     pub fn default_chunk_size(&self) -> usize {
         self.data.default_chunk_size.unwrap_or(1000)
     }

diff --git a/src/config/input.rs b/src/config/input.rs
@@ -212,7 +212,7 @@ impl Input {
         model.guard_max_input_tokens(&messages)?;
         let temperature = self.role().temperature();
         let top_p = self.role().top_p();
-        let functions = self.config.read().select_functions(model, self.role());
+        let functions = self.config.read().select_functions(self.role());
         Ok(ChatCompletionsData {
             messages,
             temperature,

diff --git a/src/config/mod.rs b/src/config/mod.rs
@@ -1116,7 +1116,7 @@ impl Config {
         Ok(())
     }
 
-    pub fn select_functions(&self, model: &Model, role: &Role) -> Option<Vec<FunctionDeclaration>> {
+    pub fn select_functions(&self, role: &Role) -> Option<Vec<FunctionDeclaration>> {
         let mut functions = vec![];
         if self.function_calling {
             if let Some(use_tools) = role.use_tools() {
@@ -1176,12 +1176,6 @@ impl Config {
                 );
                 functions = agent_functions;
             }
-            if !functions.is_empty() && !model.supports_function_calling() {
-                functions.clear();
-                if *IS_STDOUT_TERMINAL {
-                    eprintln!("{}", warning_text("WARNING: This LLM or client does not support function calling, despite the context requiring it."));
-                }
-            }
         };
         if functions.is_empty() {
             None