Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracking): allow mention tracking to be turned off, turning the … #722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djMax
Copy link

@djMax djMax commented Dec 15, 2023

…input into more of a macro expander

What did you change (functionally and technically)?

Instead of inserting the markup into the formatted (and unformatted) values, if trackMentions is false, it will just insert the display-formatted value in both, which allows editing of the FULL text in the text area instead of what happens now. Before this change, if you try to edit the text "in" a mention, it will just delete the whole mention. In our use case it is more of a macro-expander, and thus this breaks the expectations a user would have. There are probably more complex solutions available by messing with applyChangeToValue, but I don't feel confident making those changes.

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-mentions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 9:41pm

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: 7af88d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-mentions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant