Skip to content

Commit

Permalink
fix: use mousemove to focus suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
fnky committed Sep 6, 2022
1 parent ad43016 commit 4fdfdd9
Show file tree
Hide file tree
Showing 6 changed files with 1,487 additions and 1,381 deletions.
5 changes: 5 additions & 0 deletions .changeset/dry-phones-explode.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-mentions": minor
---

Focus suggestions on mouse move instead of mouse enter
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-mentions",
"version": "4.4.7",
"version": "4.5.7",
"description": "React mentions input",
"main": "dist/react-mentions.cjs.js",
"module": "dist/react-mentions.esm.js",
Expand Down
4 changes: 2 additions & 2 deletions src/MentionsInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ class MentionsInput extends React.Component {
customSuggestionsContainer ={this.props.customSuggestionsContainer}
onSelect={this.addMention}
onMouseDown={this.handleSuggestionsMouseDown}
onMouseEnter={this.handleSuggestionsMouseEnter}
onMouseMove={this.handleSuggestionsMouseMove}
isLoading={this.isLoading()}
isOpened={this.isOpened()}
ignoreAccents={this.props.ignoreAccents}
Expand Down Expand Up @@ -678,7 +678,7 @@ class MentionsInput extends React.Component {
this._suggestionsMouseDown = true
}

handleSuggestionsMouseEnter = (focusIndex) => {
handleSuggestionsMouseMove = (focusIndex) => {
this.setState({
focusIndex,
scrollFocusedIntoView: false,
Expand Down
4 changes: 2 additions & 2 deletions src/Suggestion.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ function Suggestion({
ignoreAccents,
index,
onClick,
onMouseEnter,
onMouseMove,
query,
renderSuggestion,
suggestion,
style,
className,
classNames,
}) {
const rest = { onClick, onMouseEnter }
const rest = { onClick, onMouseMove }

const renderContent = () => {
let display = getDisplay()
Expand Down
10 changes: 5 additions & 5 deletions src/SuggestionsOverlay.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function SuggestionsOverlay({
style,
customSuggestionsContainer,
onMouseDown,
onMouseEnter,
onMouseMove,
}) {
const [ulElement, setUlElement] = useState()

Expand Down Expand Up @@ -85,7 +85,7 @@ function SuggestionsOverlay({
suggestion={result}
focused={isFocused}
onClick={() => select(result, queryInfo)}
onMouseEnter={() => handleMouseEnter(index)}
onMouseMove={() => handleMouseMove(index)}
/>
)
}
Expand All @@ -98,9 +98,9 @@ function SuggestionsOverlay({
return <LoadingIndicator style={style('loadingIndicator')} />
}

const handleMouseEnter = (index, ev) => {
if (onMouseEnter) {
onMouseEnter(index)
const handleMouseMove = (index, ev) => {
if (onMouseMove) {
onMouseMove(index)
}
}

Expand Down
Loading

0 comments on commit 4fdfdd9

Please sign in to comment.